v2.12.0

.config/dotnet-tools.json

@@ -6,19 +6,22 @@
       "version": "0.6.0",
       "commands": [
         "husky"
-      ]
+      ],
+      "rollForward": false
     },
     "xamlstyler.console": {
-      "version": "3.2206.4",
+      "version": "3.2404.2",
       "commands": [
         "xstyler"
-      ]
+      ],
+      "rollForward": false
     },
     "csharpier": {
       "version": "0.26.7",
       "commands": [
         "dotnet-csharpier"
-      ]
+      ],
+      "rollForward": false
     }
   }
 }

.github/workflows/backport.yml

@@ -27,9 +27,9 @@ jobs:
               "commitConflicts": "true",
               "prTitle": "[{{sourceBranch}} to {{targetBranch}}] backport: {{sourcePullRequest.title}} ({{sourcePullRequest.number}})"
             }
-        
+
       - name: Backport Action
-        uses: sorenlouv/backport-github-action@v9.3.0
+        uses: sorenlouv/backport-github-action@v9.5.1
         with:
           github_token: ${{ secrets.GITHUB_TOKEN }}
           auto_backport_label_prefix: backport-to-

.github/workflows/release.yml

@@ -95,11 +95,13 @@ jobs:
         run: mv ./Release/linux-x64/StabilityMatrix.x86_64.AppImage ${{ env.out-name }}
 
       - name: Upload Artifact
-        uses: actions/upload-artifact@v2
+        uses: actions/upload-artifact@v4
         with:
           name: StabilityMatrix-${{ env.platform-id }}
           path: ${{ env.out-name }}
-
+          retention-days: 1
+          if-no-files-found: error
+
       - name: Create Sentry release
         if: ${{ github.event.inputs.sentry-release == 'true' }}
         uses: getsentry/action-release@v1
@@ -166,10 +168,12 @@ jobs:
         run: mv ./out/StabilityMatrix.Avalonia.exe ./out/${{ env.out-name }}
 
       - name: Upload Artifact
-        uses: actions/upload-artifact@v2
+        uses: actions/upload-artifact@v4
         with:
           name: StabilityMatrix-${{ env.platform-id }}
           path: ./out/${{ env.out-name }}
+          retention-days: 1
+          if-no-files-found: error
 
   release-macos:
     name: Release (macos-arm64)
@@ -250,10 +254,12 @@ jobs:
         run: zip -r -y "../StabilityMatrix-${{ env.platform-id }}-app.zip" "${{ env.app-name }}"
 
       - name: Upload Artifact (App)
-        uses: actions/upload-artifact@v2
+        uses: actions/upload-artifact@v4
         with:
           name: StabilityMatrix-${{ env.platform-id }}-app
           path: StabilityMatrix-${{ env.platform-id }}-app.zip
+          retention-days: 1
+          if-no-files-found: error
 
       - uses: actions/setup-node@v4
         with:
@@ -276,10 +282,12 @@ jobs:
         run: zip -r -y "../StabilityMatrix-${{ env.platform-id }}-dmg.zip" "${{ env.out-name }}"
 
       - name: Upload Artifact (dmg)
-        uses: actions/upload-artifact@v2
+        uses: actions/upload-artifact@v4
         with:
           name: StabilityMatrix-${{ env.platform-id }}-dmg
           path: StabilityMatrix-${{ env.platform-id }}-dmg.zip
+          retention-days: 1
+          if-no-files-found: error
 
   publish-release:
     name: Publish GitHub Release
@@ -300,7 +308,7 @@ jobs:
 
       # Downloads all previous artifacts to the current working directory
       - name: Download Artifacts
-        uses: actions/download-artifact@v3
+        uses: actions/download-artifact@v4
 
       # Zip each build (except macos which is already dmg)
       - name: Zip Artifacts
@@ -346,7 +354,7 @@ jobs:
 
       # Downloads all previous artifacts to the current working directory
       - name: Download Artifacts
-        uses: actions/download-artifact@v3
+        uses: actions/download-artifact@v4
 
       # Zip each build (except macos which is already dmg)
       - name: Zip Artifacts
@@ -428,7 +436,7 @@ jobs:
 
       # Downloads all previous artifacts to the current working directory
       - name: Download Artifacts
-        uses: actions/download-artifact@v3
+        uses: actions/download-artifact@v4
 
       # Zip each build (except macos which is already dmg)
       - name: Zip Artifacts

Avalonia.Gif/Avalonia.Gif.csproj

@@ -9,9 +9,15 @@
 		<BuiltInComInteropSupport>true</BuiltInComInteropSupport>
 		<EnableWindowsTargeting>true</EnableWindowsTargeting>
   </PropertyGroup>
+
+	<PropertyGroup>
+		<!-- Ignore nullable / unused warnings since this was vendored -->
+		<NoWarn>$(NoWarn);CS8765;CS8618;CS8625;CS0169</NoWarn>
+	</PropertyGroup>
+
   <ItemGroup>
     <PackageReference Include="Avalonia" Version="$(AvaloniaVersion)" />
-    <PackageReference Include="SkiaSharp" Version="2.88.7" />
+    <PackageReference Include="SkiaSharp" Version="3.0.0-preview.4.1" />
 	<PackageReference Include="DotNet.Bundle" Version="0.9.13" />
   </ItemGroup>
 

Avalonia.Gif/Decoding/GifDecoder.cs

@@ -9,6 +9,7 @@
 using System;
 using System.Buffers;
 using System.Collections.Generic;
+using System.Diagnostics.CodeAnalysis;
 using System.IO;
 using System.Linq;
 using System.Runtime.CompilerServices;
@@ -190,7 +191,9 @@
         [MethodImpl(MethodImplOptions.AggressiveInlining)]
         private void DrawFrame(GifFrame curFrame, Memory<byte> frameIndexSpan)
         {
-            var activeColorTable = curFrame.IsLocalColorTableUsed ? curFrame.LocalColorTable : Header.GlobarColorTable;
+            var activeColorTable = curFrame.IsLocalColorTableUsed
+                ? curFrame.LocalColorTable
+                : Header.GlobarColorTable;
 
             var cX = curFrame.Dimensions.X;
             var cY = curFrame.Dimensions.Y;
@@ -232,7 +235,11 @@
                 {
                     var indexColor = frameIndexSpan.Span[indexOffset + i];
 
-                    if (activeColorTable == null || targetOffset >= len || indexColor > activeColorTable.Length)
+                    if (
+                        activeColorTable == null
+                        || targetOffset >= len
+                        || indexColor > activeColorTable.Length
+                    )
                         return;
 
                     if (!(hT & indexColor == tC))
@@ -419,15 +426,21 @@
 
             unsafe
             {
                 fixed (void* src = &_bitmapBackBuffer[0])
-                    Buffer.MemoryCopy(src, targetPointer.ToPointer(), (uint)_backBufferBytes, (uint)_backBufferBytes);
+                    Buffer.MemoryCopy(
+                        src,
+                        targetPointer.ToPointer(),
+                        (uint)_backBufferBytes,
+                        (uint)_backBufferBytes
+                    );
                 _hasNewFrame = false;
             }
         }
 
         /// <summary>
         /// Processes GIF Header.
         /// </summary>
+        [MemberNotNull(nameof(Header))]
         private void ProcessHeaderData()
         {
             var str = _fileStream;
@@ -549,7 +562,9 @@
 
                 // Break the loop when the stream is not valid anymore.
                 if (_fileStream.Position >= _fileStream.Length & terminate == false)
-                    throw new InvalidProgramException("Reach the end of the filestream without trailer block.");
+                    throw new InvalidProgramException(
+                        "Reach the end of the filestream without trailer block."
+                    );
             } while (!terminate);
 
             ArrayPool<byte>.Shared.Return(tempBuf);
@@ -581,7 +596,11 @@
             currentFrame.LocalColorTableSize = (int)Math.Pow(2, (packed & 0x07) + 1);
 
             if (currentFrame.IsLocalColorTableUsed)
-                currentFrame.LocalColorTable = ProcessColorTable(ref str, tempBuf, currentFrame.LocalColorTableSize);
+                currentFrame.LocalColorTable = ProcessColorTable(
+                    ref str,
+                    tempBuf,
+                    currentFrame.LocalColorTableSize
+                );
 
             currentFrame.LzwMinCodeSize = str.ReadByteS(tempBuf);
             currentFrame.LzwStreamPosition = str.Position;

Avalonia.Gif/Decoding/InvalidGifStreamException.cs

@@ -1,9 +1,6 @@
 // Licensed under the MIT License.
 // Copyright (C) 2018 Jumar A. Macato, All Rights Reserved.
 
-using System;
-using System.Runtime.Serialization;
-
 namespace Avalonia.Gif.Decoding
 {
     [Serializable]
@@ -16,8 +13,5 @@ public InvalidGifStreamException(string message)
 
         public InvalidGifStreamException(string message, Exception innerException)
             : base(message, innerException) { }
-
-        protected InvalidGifStreamException(SerializationInfo info, StreamingContext context)
-            : base(info, context) { }
     }
 }

Avalonia.Gif/Decoding/LzwDecompressionException.cs

@@ -1,9 +1,6 @@
 // Licensed under the MIT License.
 // Copyright (C) 2018 Jumar A. Macato, All Rights Reserved.
 
-using System;
-using System.Runtime.Serialization;
-
 namespace Avalonia.Gif.Decoding
 {
     [Serializable]
@@ -16,8 +13,5 @@ public LzwDecompressionException(string message)
 
         public LzwDecompressionException(string message, Exception innerException)
             : base(message, innerException) { }
-
-        protected LzwDecompressionException(SerializationInfo info, StreamingContext context)
-            : base(info, context) { }
     }
 }

Avalonia.Gif/GifInstance.cs

@@ -55,16 +55,23 @@ public GifInstance(Stream currentStream)
             CurrentCts = new CancellationTokenSource();
 
             _gifDecoder = new GifDecoder(currentStream, CurrentCts.Token);
-            var pixSize = new PixelSize(_gifDecoder.Header.Dimensions.Width, _gifDecoder.Header.Dimensions.Height);
-
-            _targetBitmap = new WriteableBitmap(pixSize, new Vector(96, 96), PixelFormat.Bgra8888, AlphaFormat.Opaque);
+            var pixSize = new PixelSize(
+                _gifDecoder.Header.Dimensions.Width,
+                _gifDecoder.Header.Dimensions.Height
+            );
+
+            _targetBitmap = new WriteableBitmap(
+                pixSize,
+                new Vector(96, 96),
+                PixelFormat.Bgra8888,
+                AlphaFormat.Opaque
+            );
             GifPixelSize = pixSize;
 
             _totalTime = TimeSpan.Zero;
 
             _frameTimes = _gifDecoder
-                .Frames
-                .Select(frame =>
+                .Frames.Select(frame =>
                 {
                     _totalTime = _totalTime.Add(frame.FrameDelay);
                     return _totalTime;
@@ -138,10 +145,10 @@ public void Dispose()
 
         internal WriteableBitmap ProcessFrameIndex(int frameIndex)
         {
-            _gifDecoder.RenderFrame(frameIndex, _targetBitmap);
+            _gifDecoder.RenderFrame(frameIndex, _targetBitmap!);
             _currentFrameIndex = frameIndex;
 
-            return _targetBitmap;
+            return _targetBitmap!;
         }
     }
 }

Avalonia.Gif/InvalidGifStreamException.cs

@@ -1,6 +1,3 @@
-using System;
-using System.Runtime.Serialization;
-
 namespace Avalonia.Gif
 {
     [Serializable]
@@ -13,8 +10,5 @@ public InvalidGifStreamException(string message)
 
         public InvalidGifStreamException(string message, Exception innerException)
             : base(message, innerException) { }
-
-        protected InvalidGifStreamException(SerializationInfo info, StreamingContext context)
-            : base(info, context) { }
     }
 }

Build/_utils.sh

@@ -0,0 +1,9 @@
+#!/bin/bash
+
+print_hyperlink() {
+    local url="$1"
+    local text="$2"
+
+    # macOS Terminal supports clickable links in the following format
+    printf "\033]8;;%s\a%s\033]8;;\a" "$url" "$text"
+}

Build/build_macos_app.sh

@@ -1,26 +1,59 @@
-#!/bin/sh
+#!/bin/bash
 
+output_dir="$(pwd)/out/osx-arm64/"
+app_name="Stability Matrix.app"
+
+. "./_utils.sh" > /dev/null 2>&1 || . "${BASH_SOURCE%/*}/_utils.sh"
+
+# Parse args
 while getopts v: flag
 do
     case "${flag}" in
-        v) version=${OPTARG};;
-        *) echo "Invalid option";;
+        v) 
+          version=${OPTARG}
+          ;;
+        *) 
+          echo "Invalid option: -$OPTARG" >&2
+          exit 2
+          ;;
     esac
 done
 
+shift $((OPTIND - 1))
+echo $"Passing extra args to msbuild: $@"
+
+set -e
+
+# Build the app
 dotnet \
 msbuild \
 StabilityMatrix.Avalonia \
 -t:BundleApp \
 -p:RuntimeIdentifier=osx-arm64 \
 -p:UseAppHost=true \
 -p:Configuration=Release \
--p:CFBundleShortVersionString="$version" \
 -p:SelfContained=true \
 -p:CFBundleName="Stability Matrix" \
 -p:CFBundleDisplayName="Stability Matrix" \
 -p:CFBundleVersion="$version" \
--p:PublishDir="$(pwd)/out/osx-arm64/bin" \
+-p:CFBundleShortVersionString="$version" \
+-p:PublishDir="${output_dir:?}/bin" \
+"$@"
+
+target_plist_path="${output_dir:?}/bin/${app_name:?}/Contents/Info.plist"
 
+echo "> Checking Info.plist..."
+file "${target_plist_path:?}"
+plutil -lint "${target_plist_path:?}"
+
+echo "> Copying app to output..."
+# Delete existing file
+rm -rf "${output_dir:?}/${app_name:?}"
 # Copy the app out of bin
-cp -r ./out/osx-arm64/bin/Stability\ Matrix.app ./out/osx-arm64/Stability\ Matrix.app
+cp -r "${output_dir:?}/bin/${app_name:?}" "${output_dir:?}/${app_name:?}"
+
+# Print output location
+echo "[App Build Completed]"
+print_hyperlink "file:///${output_dir:?}" "${output_dir:?}"
+print_hyperlink "file:///${output_dir:?}/${app_name:?}" "${app_name:?}"
+echo ""