Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quickly adding unet path for ComfyUI #833

Merged
merged 3 commits into from
Aug 20, 2024
Merged

Conversation

jeremydk
Copy link
Contributor

Threw this together quickly to try to resolve #831 (and #805 among others) - We're just missing a mapping in the config, and it looks like this should add it.

Copy link

github-actions bot commented Aug 15, 2024

CLA Assistant Lite bot CLA Assistant bot All Contributors have signed the CLA.

@jeremydk
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

@mohnjiles
Copy link
Contributor

Thanks for the PR! It looks like this would only work for the symlink setup however - you'll need to also add the config option in the SetupModelFoldersConfig method for that to work as well.

@mohnjiles
Copy link
Contributor

Sorry, one last place needs an update for existing configs 😅

@jeremydk
Copy link
Contributor Author

Sorry, one last place needs an update for existing configs 😅

No worries at all, I'll get a commit up shortly.

@jeremydk
Copy link
Contributor Author

That should be clean now -- should've grepped for prompt_expansion the first time around, thought I caught them all.

Appreciate the work on this project so much. Thanks a ton!

Copy link
Member

@ionite34 ionite34 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you!

@mohnjiles mohnjiles merged commit dcf8a40 into LykosAI:main Aug 20, 2024
3 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Aug 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add unet extra path to ComfyUi Extra Paths Yaml
3 participants