Merge pull request #137 from LykosAI/main

LykosAI · Sep 19, 2023 · 4cb06f9 · 4cb06f9
2 parents 64180c0 + 2caa4d9
commit 4cb06f9
Show file tree

Hide file tree

Showing 3 changed files with 14 additions and 2 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -5,6 +5,10 @@ All notable changes to Stability Matrix will be documented in this file.
 The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.1.0/),
 and this project adheres to [Semantic Versioning 2.0](https://semver.org/spec/v2.0.0.html).
 
+## v2.4.5
+### Fixed
+- Fixed "Library Dir not set" error on launch
+
 ## v2.4.4
 ### Added
 - Added button to toggle automatic scrolling of console output

diff --git a/StabilityMatrix.Avalonia/ViewModels/LaunchPageViewModel.cs b/StabilityMatrix.Avalonia/ViewModels/LaunchPageViewModel.cs
@@ -87,7 +87,7 @@ public partial class LaunchPageViewModel : PageViewModelBase, IDisposable, IAsyn
     private BasePackage? runningPackage;
 
     [ObservableProperty]
-    private bool autoScrollToEnd;
+    private bool autoScrollToEnd = true;
 
     public virtual BasePackage? SelectedBasePackage =>
         PackageFactory.FindPackageByName(SelectedPackage?.PackageName);

diff --git a/StabilityMatrix.Core/Services/SettingsManager.cs b/StabilityMatrix.Core/Services/SettingsManager.cs
@@ -190,7 +190,15 @@ Expression<Func<Settings, TValue>> settingsProperty
             );
 
             settingsSetter(Settings, sourceGetter(source));
-            SaveSettingsAsync().SafeFireAndForget();
+
+            if (IsLibraryDirSet)
+            {
+                SaveSettingsAsync().SafeFireAndForget();
+            }
+            else
+            {
+                Logger.Warn("[RelayPropertyFor] LibraryDir not set when saving");
+            }
 
             // Invoke property changed event
             SettingsPropertyChanged?.Invoke(this, new PropertyChangedEventArgs(propertyName));