Skip to content

Commit

Permalink
Merge pull request LykosAI#875 from ionite34/no-more-binary
Browse files Browse the repository at this point in the history
don't use binary search & fix some other misc errors
  • Loading branch information
mohnjiles authored Nov 5, 2024
2 parents 6eccc3c + 1ad4eb5 commit 7ae0a97
Show file tree
Hide file tree
Showing 4 changed files with 10 additions and 4 deletions.
5 changes: 5 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,9 @@ and this project adheres to [Semantic Versioning 2.0](https://semver.org/spec/v2
## v2.13.0-dev.3
### Added
- Added more base model types to the CivitAI Model Browser & Checkpoint Manager
### Fixed
- Fixed some instances of Civitai model browser not loading new results
- Fixed "Unsupported Torch Version: Cuda" errors when installing a1111

## v2.13.0-dev.2
### Added
Expand Down Expand Up @@ -51,6 +54,8 @@ and this project adheres to [Semantic Versioning 2.0](https://semver.org/spec/v2
- Fixed some cases of FileTransferExists error when running re/Forge or Automatic1111
- Fixed update check not happening on startup for some users
- Fixed error when installing Automatic1111 on macOS
- Fixed some instances of Civitai model browser not loading new results
- Fixed "Unsupported Torch Version: Cuda" errors when installing a1111

## v2.12.2
### Added
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -162,7 +162,7 @@ or nameof(HideEarlyAccessModels)
)
.DisposeMany()
.Filter(filterPredicate)
.SortAndBind(ModelCards, sortPredicate, new SortAndBindOptions { UseBinarySearch = true })
.SortAndBind(ModelCards, sortPredicate)
.Subscribe();

settingsManager.RelayPropertyFor(
Expand Down
4 changes: 2 additions & 2 deletions StabilityMatrix.Core/Models/Packages/A3WebUI.cs
Original file line number Diff line number Diff line change
Expand Up @@ -212,7 +212,7 @@ public override async Task InstallPackage(
var torchVersion = options.PythonOptions.TorchIndex ?? GetRecommendedTorchVersion();

var requirements = new FilePath(installLocation, "requirements_versions.txt");
var pipArgs = options.PythonOptions.TorchIndex switch
var pipArgs = torchVersion switch
{
TorchIndex.Mps
=> new PipInstallArgs()
Expand All @@ -227,7 +227,7 @@ await requirements.ReadAllTextAsync(cancellationToken).ConfigureAwait(false),
.WithTorch("==2.1.2")
.WithTorchVision("==0.16.2")
.WithTorchExtraIndex(
options.PythonOptions.TorchIndex switch
torchVersion switch
{
TorchIndex.Cpu => "cpu",
TorchIndex.Cuda => "cu121",
Expand Down
3 changes: 2 additions & 1 deletion StabilityMatrix.Core/Models/Packages/OneTrainer.cs
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,8 @@ public override async Task InstallPackage(
await using var venvRunner = await SetupVenvPure(installLocation).ConfigureAwait(false);

progress?.Report(new ProgressReport(-1f, "Installing requirements", isIndeterminate: true));
var requirementsFileName = options.PythonOptions.TorchIndex switch
var torchVersion = options.PythonOptions.TorchIndex ?? GetRecommendedTorchVersion();
var requirementsFileName = torchVersion switch
{
TorchIndex.Cuda => "requirements-cuda.txt",
TorchIndex.Rocm => "requirements-rocm.txt",
Expand Down

0 comments on commit 7ae0a97

Please sign in to comment.