Add a `Context` and use it for interning strings and `Rule`s. #4

eddyb · 2019-05-16T14:36:56Z

(The names IStr and IRule were suggested by @Centril)

Among other advantages, this will get rid of Rc usage, and make "rule-keyed maps" much cheaper (as they will no longer compare/hash entire "rule trees").

…` versions.

CAD97

A few suggestions inline but otherwise this looks good.

src/context.rs

src/lib.rs

src/rule.rs

eddyb added 7 commits May 15, 2019 13:01

Switch from ordermap to indexmap.

ef0619f

Move Rule and RuleWithNamedFields into a rule module.

d742a73

Introduce a context object and interning (for strings).

2cfe640

rule: introduce a FieldPathset to simplify building methods.

c0d9669

rule: split repeat_{many,more} builder methods into plain and `_sep…

4165cdb

…` versions.

rule: put all the rule-building methods/operators behind a "build API".

d10ea9d

Intern Rules as well.

00b27f5

CAD97 approved these changes May 16, 2019

View reviewed changes

src/context.rs Show resolved Hide resolved

src/context.rs Show resolved Hide resolved

src/lib.rs Show resolved Hide resolved

src/rule.rs Show resolved Hide resolved

eddyb merged commit eb47b51 into master May 20, 2019

eddyb deleted the intern branch May 20, 2019 14:19

eddyb mentioned this pull request May 20, 2019

Update for grammer using interning. rust-lang/gll#119

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add a `Context` and use it for interning strings and `Rule`s. #4

Add a `Context` and use it for interning strings and `Rule`s. #4

eddyb commented May 16, 2019

CAD97 left a comment

Add a Context and use it for interning strings and Rules. #4

Add a Context and use it for interning strings and Rules. #4

Conversation

eddyb commented May 16, 2019

CAD97 left a comment

Choose a reason for hiding this comment

Add a `Context` and use it for interning strings and `Rule`s. #4

Add a `Context` and use it for interning strings and `Rule`s. #4