Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix top-level edits for non-admin users #705

Merged
merged 1 commit into from
Aug 29, 2020
Merged

Fix top-level edits for non-admin users #705

merged 1 commit into from
Aug 29, 2020

Conversation

kamil4
Copy link
Contributor

@kamil4 kamil4 commented Aug 28, 2020

Fix #669.

I left the smart album test for now but given the discussion we had recently, that should eventually probably go away; I just don't want to deal with any collateral damage it might cause right now.

@kamil4 kamil4 requested a review from ildyria August 28, 2020 14:42
@sonarcloud
Copy link

sonarcloud bot commented Aug 28, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov
Copy link

codecov bot commented Aug 28, 2020

Codecov Report

Merging #705 into master will not change coverage.
The diff coverage is 0.00%.

Copy link
Contributor

@d7415 d7415 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Untested, but looks good.

@ildyria ildyria merged commit 99ba2f2 into master Aug 29, 2020
@delete-merged-branch delete-merged-branch bot deleted the fix-669 branch August 29, 2020 10:07
Aleshus pushed a commit to Aleshus/Lychee that referenced this pull request Sep 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Regression] Non admin users cannot add photos or albums
3 participants