Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace hardcoded php7 with something generic #1173

Merged
merged 2 commits into from
Dec 17, 2021
Merged

Replace hardcoded php7 with something generic #1173

merged 2 commits into from
Dec 17, 2021

Conversation

kamil4
Copy link
Contributor

@kamil4 kamil4 commented Dec 17, 2021

No description provided.

@codecov
Copy link

codecov bot commented Dec 17, 2021 •
edited
Loading

Codecov Report

Merging #1173 (aeee43f) into master (c6b3de9) will decrease coverage by 1.04%.
The diff coverage is n/a.

@sonarcloud
Copy link

sonarcloud bot commented Dec 17, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

ildyria
ildyria approved these changes Dec 17, 2021
View reviewed changes
Copy link
Member

@ildyria ildyria left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

nagmat84
nagmat84 reviewed Dec 17, 2021
View reviewed changes
Copy link
Collaborator

@nagmat84 nagmat84 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. However, I cannot test this branch explicitly right now. So don't wait for me to merge.

d7415
d7415 approved these changes Dec 17, 2021
View reviewed changes
Copy link
Contributor

@d7415 d7415 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Bearing in mind I don't do apache.

@kamil4 kamil4 merged commit a7de020 into master Dec 17, 2021
@delete-merged-branch delete-merged-branch bot deleted the fix-htaccess branch December 17, 2021 15:27
@oblomow oblomow mentioned this pull request Jan 14, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nagmat84 nagmat84 nagmat84 approved these changes

@ildyria ildyria ildyria approved these changes

@d7415 d7415 d7415 approved these changes

Assignees

@ildyria ildyria

@d7415 d7415

@nagmat84 nagmat84

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kamil4 @ildyria @d7415 @nagmat84