Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improved regex deletion #179

Closed
wants to merge 2 commits into from
Closed

improved regex deletion #179

wants to merge 2 commits into from

Conversation

ildyria
Copy link
Member

@ildyria ildyria commented Jan 17, 2024

Fixes #178

@ildyria
Copy link
Member Author

ildyria commented Jan 17, 2024

Command tested in my docker container:

root@e7d513f87a2f:/var/www/html/Lychee# find /var/www/html/Lychee -regex '.*/[Tt]ests?/.*' | wc
    282     284   18558
root@e7d513f87a2f:/var/www/html/Lychee# find . -regex '.*/[Tt]ests?/.*' | wc
    282     284   13200
root@e7d513f87a2f:/var/www/html/Lychee# find /var/www/html/Lychee -wholename '*/[Tt]ests/*' | wc
    230     232   14288
root@e7d513f87a2f:/var/www/html/Lychee# find /var/www/html/Lychee -wholename '*/[Tt]est/*' | wc
     52      52    4270

@d7415
Copy link
Contributor

d7415 commented Jan 17, 2024

I just built this and the tests folder is still there with all the samples :(

@d7415
Copy link
Contributor

d7415 commented Jan 18, 2024

FWIW the old find but with pull path instead of . doesn't work either. I'll try to look at what find finds during the build when I get a chance, to check it's actually trying to delete. Running the old find from within the finished container deletes everything in the tests directory (but not the directory itself).

@ildyria
Copy link
Member Author

ildyria commented Jan 18, 2024

Running the old find from within the finished container deletes everything in the tests directory (but not the directory itself).

It is more than just THAT test directory, it is aimed to target all the test directory in the vendor.

@d7415
Copy link
Contributor

d7415 commented Jan 18, 2024

It is more than just THAT test directory, it is aimed to target all the test directory in the vendor.

Yeah, but that one's easy to test and big.

@ildyria ildyria closed this Feb 1, 2024
@ildyria ildyria deleted the improve-docker-file branch February 1, 2024 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Full source code in the docker image
2 participants