Jdom/plugin/thai #510
Merged
Jdom/plugin/thai #510
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaydom28
commented
Nov 2, 2024
| is_word_char = re.match(pattern, word) is not None | ||
| is_end_of_sentence = word in language.regexp_split_sentences | ||
| if is_end_of_sentence: | ||
| is_word_char = False |
There was a problem hiding this comment.
Just wanted to leave a comment about this logic here,
In Thai the "period" punctuation is ฯ and in my tests, the parser was showing it as a word and I figured it didn't make sense for punctuation to be words so that is why I have is_word_char set to False if the text is a sentence delimiter
There was a problem hiding this comment.
Right, sometimes there maybe funny cases like this where you have to hardcode it.
|
Looks great, thanks! |
|
Released to pypi woot. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.