Revert dict tab focus fix and sandbox dict tab iframes #473
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit a27e0a7.
This reverts commit 98e7ca1.
One possible solution to preven dictionary iframes from stealing focus is to enable the CSP sandbox on each iframe. If a bare `sandbox` attribute is used, then autofocus from iframes should be blocked. Unfortunately this has the side effect of blocking some online dictionary that require additional feature policies such as `allow-same-origin` and `allow-scripts`. In particular the following dictionaries mentioned in issue LuteOrg#469 require these policies to load correctly: - https://korean.dict.naver.com/koendict/#/search?query=### - https://en.dict.naver.com/#/search?query=###
|
Hi @cblanken - I wonder if this should be split out further, with one PR just to revert the existing change, and another to add the sandbox etc attributes in that new line. I wouldn't want to "fix" one problem just to cause another. Then we could look at the extra policy stuff more carefully. Thoughts? |
|
Chatted briefly w/ @cblanken on discord, this is a draft idea to investigate sandboxing only. I'll revert the old PR, will keep this as an idea only for sandboxing investigations. Thanks!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One possible solution to prevent dictionary iframes from stealing focus is to
enable the CSP sandbox on each iframe. If a bare
sandboxattribute is used,then autofocus from iframes should be blocked. Unfortunately this has the side
effect of blocking some online dictionary that require additional feature
policies such as
allow-same-originandallow-scripts.In particular the following dictionaries mentioned in issue #469 require these policies
to load correctly: