Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Z-index order fix #127

Merged
merged 2 commits into from
Jan 12, 2024
Merged

Z-index order fix #127

merged 2 commits into from
Jan 12, 2024

Conversation

webofpies
Copy link
Contributor

@webofpies webofpies commented Jan 11, 2024

Fixes the issue introduced after mobile view update.
image

Main issue was that the tooltip was being created under the audio player if the word was close to the bottom of the page. Now it's created over the player.
But a better solution would be detecting the audio player as the "end of the page" and showing the tooltip above the word.

@jzohrab
Copy link
Collaborator

jzohrab commented Jan 12, 2024

All makes sense, thanks!

@jzohrab jzohrab merged commit 61ba29e into LuteOrg:develop Jan 12, 2024
9 checks passed
@webofpies webofpies deleted the z-index-fix branch January 13, 2024 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants