-
Notifications
You must be signed in to change notification settings - Fork 13
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix(limel-dialog): fix broken markup and resulting styling of the header
The slot>header>h1-h6 structure is not supported by MDCDialog. Change to h2 only to support correct styling by MDC. BREAKING CHANGE: While backwards compatible in most cases, some functionality has been removed. If the `heading`-attribute is not set, the text-content of anything injected into the header-slot is copied and placed in the new h2-element. But any use of `<em>`, `<strong>`, or similar, will be stripped. So will any `<a>` tags. But none of these should be used in a dialog-heading anyway.
- Loading branch information
1 parent
22bea52
commit 3050fe2
Showing
2 changed files
with
18 additions
and
6 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters