update installation guide in readme #103
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello. As stated in the docs, we only support beta/alpha versions for now, but indeed, the installation steps should also include it. However, this particular README should be updated: |
|
Ok, Then we might need to declare ResizeMode types as devs might using react-native-video for other uses in the same project which can lead to errors. If you agree on this. I'll raise another PR after that |
|
Closing this in favor of #108 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolve TypeError: Cannot read property 'COVER' of undefined
If somebody has installed different version of react-native-video. ResizeMode type does not get available in that version
How to reproduce
Try with different version of react-native-video library (without alpha or beta versions)