Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature - Make ApolloPlayer an Audience #163

Merged
merged 1 commit into from
Aug 28, 2024
Merged

Feature - Make ApolloPlayer an Audience #163

merged 1 commit into from
Aug 28, 2024

Conversation

vectrixdevelops
Copy link
Contributor

@vectrixdevelops vectrixdevelops commented Aug 21, 2024 •
edited by ItsNature
Loading

Overview

Description:
Makes the ApolloPlayer an Audience so it can be used with Adventure better.

Code Example (If applicable):

Apollo.getPlayerManager().getPlayer(UUID.randomUUID())
    .ifPresent(player -> player.sendMessage(Component.text("Hello World!")));

Review Request Checklist

  • Your code follows the style guidelines of this project.
  • I have performed a self-review of my code.
  • I have tested this change myself. (If applicable)
  • I have made corresponding changes to the documentation. (If applicable)
  • The branch name follows the projects naming conventions. (e.g. feature/add-module & bugfix/fix-issue)

@TrentinTheKid TrentinTheKid added the type: Enhancement Feature improvement or addition label Aug 26, 2024
@ItsNature ItsNature merged commit b71d689 into version/1.1.5 Aug 28, 2024
2 checks passed
@ItsNature ItsNature deleted the feature/player-audience branch August 28, 2024 13:48
@ItsNature ItsNature mentioned this pull request Sep 5, 2024
Merged
ItsNature added a commit that referenced this pull request Oct 28, 2024
@ItsNature @TrentinTheKid
@Rhodless @vectrixdevelops @LunarClientBot
Version - 1.1.6 (#183)
d155e01 
* Deploy as 1.1.5-SNAPSHOT

* Lightweight (#162)

* WIP: lightweight docs

* Lightweight doc revamp

* Simple touch-ups

* Switch methods to tabs

* Attempt to fix tabs

* Close tabs

* again

* Revert tabs

* Attempt to add tabs once more

* Add tab import

* Fix tab import

* Add lightweight-wrapper & lightweight-example modules

* Register "lunar:apollo" for player detection

* Add protobuf repo section

* Remove lightweight-wrapper & lightweight-example

* Add the Apollo repository & protobuf-java-util as dependency to docs

* Use correct `

* Fix typo

---------

Co-authored-by: TrentinTheKid <[email protected]>

* fix: ClassCastException for Color conversion in newer Java versions (#161)

* fix: ClassCastException for Color conversion in newer Java versions

This commit corrects the issue by converting the Color object to its RGB hex string representation.

* fix: Restore HEX string compatibility while retaining Color object support

This commit addresses the regression introduced in the previous fix that enabled Color object usage but broke HEX string compatibility. The code has been adjusted to ensure that both HEX strings (e.g., "#FFFFAA00") and Color objects (e.g., Color.RED) can be used interchangeably when setting color values in options.set(). This fix ensures backward compatibility with the previous behavior while retaining the ability to use Color objects without causing a ClassCastException.

* Throw RuntimeException for invalid Color types

---------

Co-authored-by: ItsNature <[email protected]>

* make player an audience (#163)

* Deploy as 1.1.6-SNAPSHOT

* Feature - Tebex Module (#167)

* Implement Tebex module

* Rename TebexCheckoutSupportType to TebexEmbeddedCheckoutSupport & add basket id parameter to the tebex command

* basketId -> basketIdent

* Remove callout & doc page

---------

Co-authored-by: TrentinTheKid <[email protected]>

* Feature - Add Tebex locale field (#174)

* Add locale field to the tebex module

* Add seperate method to not break the API

* Use correct locale arg

* Lightweight: Documentation (#172)

* Add a bunch of lightweight examples

* Add more examples

* Even more examples...

* More examples & prepare for example plugin merge

* Fix adventure usages

* Testable state

* Add more notes

* Add switch implementation command

* Finish more examples, start working on markdown

* Spotless fixes

* Update beam.mdx with new examples

* Finish team examples

* More markdown work

* Add missing import to chat.mdx

* Move builders outside tabs again

* Fix remaining serialization issues

* Add more markdown examples

* Add hologram & limb examples

* move builders inside API tab, add nametag, nickhider & notification examples

* Finish proto examples

* Remove object utils

* add temp layout

* Finish all Json Examples

* Add Tebex module locale field to lightweight examples

* The merge!

* Start lightweight.mdx rewrite

* Close tab

* Import callout

* ADd modsettings examples

* richpresence, serverrule, staffmod, stopwatch, title, tntcountdown, tranfser, vignette & waypoint markdown examples

* Protobuf Lightweight Documentation

* Minor changes

* Updating player world code & markdown, packet enrichment & minor parameter fixups

* Fix links

* Fix the fixed links

* Spotless fixes

* Add lightweight callout to intro

* add intro to meta json

* Finish JSON lightweight docs

* Remove old lightweight.mdx

* Link usage methods, add module examples note

* resolve callout issue?

* Rebuild

* Team markdown examples

* update callout

* update callout

* remove placeholder text

* Remove build status

* Replace Component#appendNewLine with Component.append(Component.newline()) for backwards compatibility

* Default implementation type to API

* Remove protobuf-java-util dependency

* Final touch-ups

* fix typo

* Wording Change

* Lightning -> Lighting

* Use Futures for Roundtrip example & implement timeout

* Mark player data fields with `@Nullable`

---------

Co-authored-by: TrentinTheKid <[email protected]>

* Feature - Add packet spam debug command example (#177)

* add spam packet debug command

* decrease delay on packet spam

* improve spam packets command

---------

Co-authored-by: ItsNature <[email protected]>

* Sync LunarClient Mods & Options (#181)

* Sync LunarClient Mods & Options

* Update version tags to 1.1.6

---------

Co-authored-by: LunarClient Bot <[email protected]>

* Bump to 1.1.6 (#182)

---------

Co-authored-by: TrentinTheKid <[email protected]>
Co-authored-by: Hugo <[email protected]>
Co-authored-by: Connor <[email protected]>
Co-authored-by: LunarClient Bot <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ItsNature ItsNature ItsNature approved these changes

Assignees
No one assigned
Labels
type: Enhancement Feature improvement or addition
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@vectrixdevelops @ItsNature @LunarClientBot @TrentinTheKid