chore: add Github action to build provider #64
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tommyknows
force-pushed
the
build-provider
branch
4 times, most recently
from
f13f754 to
3e95311
Compare
We want to get rid of the provider-build step in CSE, building the providers in their own repos makes more sense.
tommyknows
force-pushed
the
build-provider
branch
from
3e95311 to
c59b88d
Compare
craigfurman
approved these changes
Nov 22, 2023
| go build -o bin/terraform-provider-azurerm.linux.amd64 . | ||
| - name: Verify Boringcrypto | ||
| run: | | ||
| go run rsc.io/goversion@master -crypto bin/terraform-provider-azurerm.linux.amd64 | grep -q '(boring crypto)' |
There was a problem hiding this comment.
Are we 100% sure this certifies the crypto as boring? We've been burned here before... if we're sure, no worries, otherwise let's bust out our trusty go tool nm
There was a problem hiding this comment.
I've had a look at the implementation and it's a very similar check to the go tool nm we had before: https://github.com/rsc/goversion/blob/3a30cee7003ec5dc0903682e79b3059c8e101952/version/read.go#L60
But that implementation looks more solid & thorough than the go tool & grep chain 😄
tommyknows
added a commit
that referenced
this pull request
Nov 22, 2023
chore: add Github action to build provider
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We want to get rid of the provider-build step in CSE, building the providers in their own repos makes more sense.