Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FlipMove relies on the
transitionend
event to know when a transition has ended, and thus call theonFinish
andonFinishAll
callbacks. However, in some cases, thetransitionend
event doesn't fire. This means that FlipMove gets into a broken state, whereremainingAnimations
never goes back to 0. Thus an animation will never fully complete, and FlipMove will entirely stop working.I believe this happens when the list or element components are re-rendered really fast, and FlipMove doesn't do quite the correct reconciling to know which elements are mid-transition.
To solve this, I am taking a page out of react-bootstrap's playbook, and using
setTimeout
as a fallback to make sure that thetransitionend
event is definitely fired.https://github.dev/react-bootstrap/dom-helpers