Separate test:security task out from test:static #558
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davereid
changed the title
Comment on lines
+8
to
+9
| schedule: | ||
| - cron: '0 0 * * *' |
There was a problem hiding this comment.
Is there an option for "random 24 hour period"? Or does github already load balance these things?
There was a problem hiding this comment.
I believe that GitHub already does their own load balancing on schedules, you'll often see them occur at off-minutes around the requested schedule.
.github/workflows/TestStatic.yml
Outdated
Comment on lines
64
to
66
| - name: Run Security Tests | ||
| if: ${{ github.event_name == 'schedule' }} | ||
| run: ddev task test:security |
There was a problem hiding this comment.
I wonder if we should update the name. Otherwise, reviewers will see "Run security tests" in regular PRs, and wonder why they're skipped?
|
Thanks @davereid ! We discussed this today and decided to go with #112 (comment) Give me a shout if you think that's not the direction we should go in and we can re-open this 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #112
How this affects consumers:
task test:staticwill no longer run thetest:securitytask by default.How this affects Drainpipe
task test:securitycommand as a best example.