Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix composer install with --no-cache flag #520

Merged
merged 7 commits into from
Apr 15, 2024

Conversation

justafish
Copy link
Member

@justafish justafish commented Apr 11, 2024

Installing drainpipe doesn't work with composer install --no-cache as calling $this->cache->getRoot() on a disabled cache returns /dev/null, resulting in the following error:

🪠 [Drainpipe] vendor/lullabot/drainpipe/scaffold/env/dotenv.php' missing from autoload-dev files

In Filesystem.php line 260:
                                                                               
  /dev/null/files/lullabot/drainpipe/bin/task/3.28.0 does not exist and could  
   not be created:                                                             

Which can be seen in the test added in the first commit: https://github.com/Lullabot/drainpipe/actions/runs/8647099796/job/23707817952

@github-actions github-actions bot temporarily deployed to pantheon-pr-520 April 11, 2024 13:00 Destroyed
@deviantintegral deviantintegral added bug Something isn't working client affected labels Apr 11, 2024
@justafish justafish marked this pull request as draft April 12, 2024 09:41
@github-actions github-actions bot temporarily deployed to pantheon-pr-520 April 12, 2024 09:57 Destroyed
@justafish justafish self-assigned this Apr 12, 2024
@justafish justafish marked this pull request as ready for review April 12, 2024 10:04
src/BinaryInstaller.php Outdated Show resolved Hide resolved
Copy link
Collaborator

@leonel-lullabot leonel-lullabot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested this solution on the project where I saw the error, and now I can run composer install --no-cache without errors. Thanks @justafish!

@github-actions github-actions bot temporarily deployed to pantheon-pr-520 April 15, 2024 12:47 Destroyed
@justafish justafish merged commit 4320a29 into main Apr 15, 2024
35 of 36 checks passed
@justafish justafish deleted the justafish/fix-composer-no-cache branch April 15, 2024 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working client affected
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants