-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update README.md contributor and release docs #237
Conversation
A rough start.
Co-authored-by: Andrew Berry <[email protected]>
I've marked this as high as getting docs for the release process will eventually let us get to a scheduled release regardless of PTO or other time. |
I thought drainpipe-dev was supposed to have a release for every drainpipe release. https://github.com/Lullabot/drainpipe 3.4.1 https://github.com/Lullabot/drainpipe-dev 3.40 DOES drainpipe-dev and drainpipe always need to be released together with matching versions?? Did something change? Am I mis-remembering? cc @beto-aveiga @justafish |
Yes I believe this is the case, they should always be released together with the same version. The most recent release now matches for both due to a technical issue that failed creating the release due to an expired access token. I can add some notes I took during last week's release process. |
Resolved conflict by keeping both .gitignore additions, and picking one TOC. Will regenerate TOC.
npm install -g doctoc; doctoc README.md
@davereid I resolved the conflicts and updated the TOC. Did you want to ...
|
@YesCT I added my release process notes and solved the Git conflicts. |
Thank you! sorry I left the conflict partially in still. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great to me! (I can't approve it, since I was the original author of the PR.)
README.md
Outdated
|
||
These are guidelines for conducting peer reviews on automated dependency update pull requests created by Renovate. | ||
|
||
#### Overview |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need an overview section here? Could it not just be a part of this section above with only one sentence?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cc @mrdavidburns just trying to figure out the best way to merge this new section with the work that was merged in #411
################ | ||
# Editors / OS # | ||
################ | ||
.idea | ||
.DS_Store | ||
.vscode |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@YesCT you might be interested in https://github.com/github/gitignore/tree/main?tab=readme-ov-file. It's generally recommended to put these in your global .gitignore
so it automatically applies to all projects.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will do. And I'll pass on that feedback to our other projects where we add this.
Ready for review/merge!
Todo: