Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generate Environment Indicator settings #369

Closed
deviantintegral opened this issue Jan 30, 2024 · 4 comments · Fixed by #552
Closed

Generate Environment Indicator settings #369

deviantintegral opened this issue Jan 30, 2024 · 4 comments · Fixed by #552
Assignees
@geekygnr
Labels
client affected enhancement New feature or request question Further information is requested

Comments

@deviantintegral
Copy link
Member

Let's investigate automatically adding environment indicator settings, since we use it on all projects: https://architecture.lullabot.com/adr/20210609-environment-indicator/
@deviantintegral deviantintegral added the enhancement New feature or request label Jan 30, 2024
@deviantintegral deviantintegral added question Further information is requested client affected labels Feb 19, 2024
@geekygnr geekygnr self-assigned this Apr 26, 2024
@geekygnr
Copy link
Contributor

I am confused by this ticket:

My first instinct was something like this was needed: https://github.com/Lullabot/drainpipe/blob/main/scaffold/tugboat/settings.tugboat.php.twig#L32

But it exists already.

I am confirming function now.

@geekygnr
Copy link
Contributor

I tested against a bare bones Drupal set up with environment indicator enabled. It seems to function as required on tugboat.

I am going to see if this is/can be set up for other environments

@geekygnr
Copy link
Contributor

Pantheon seems to have a similar set up: https://github.com/Lullabot/drainpipe/blob/main/scaffold/pantheon/settings.pantheon.php#L94

geekygnr added a commit that referenced this issue Apr 29, 2024
@geekygnr
#369: have code to set environment indicator for ddev.
1d42221
geekygnr added a commit that referenced this issue Apr 29, 2024
@geekygnr
#369: Adjust which settings file is getting updated.
1e9ab3d
@geekygnr geekygnr mentioned this issue Apr 29, 2024
Merged
@geekygnr
Copy link
Contributor

Created something to automatically configure ddev.

justafish added a commit that referenced this issue May 1, 2024
@geekygnr @justafish
Issue #369: Inject environment indicators into DDEV settings (#552)
93ce8a9 
* #369: have code to set environment indicator for ddev.

* #369: Adjust which settings file is getting updated.

---------

Co-authored-by: Sally Young <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@geekygnr geekygnr

Labels
client affected enhancement New feature or request question Further information is requested
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Issue #369: Inject environment indicators into DDEV settings Lullabot/drainpipe
2 participants
@deviantintegral @geekygnr