Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Amp spike experiment #254

Closed
wants to merge 18 commits into from
Closed

Conversation

marcelovani
Copy link

@marcelovani marcelovani commented Dec 7, 2018

I am documenting my findings on the experiment of joining powers of AMP WP Plugin and AMP Library for Drupal.
See the README here
https://github.com/dennisinteractive/amp-library/tree/amp-spike/AMP%20Spike

@marcelovani marcelovani closed this Dec 7, 2018
@marcelovani marcelovani reopened this Dec 7, 2018
@karens
Copy link
Member

karens commented Apr 9, 2019

@marcelovani I'm interested in this option and curious how stable you think this is?

@westonruter
Copy link

@karens See also this detailed comment that @marcelovani made: #231 (comment)

I haven't yet been able to digest the comment, largely in part to my unfamiliarity with the Drupal module (and Drupal generally!).

@marcelovani How does this PR relate to that issue?

@marcelovani
Copy link
Author

Hello @karens and @westonruter This pr was created only to generate the readme with the documentation. The content of the Readme was pasted in the thread 231. We can close it now.
With regards to the spike, we can continue the discussion on that thread, but there isn't any stable code, we still need to decide how to approach it and how to make a library that can be used by multiple platforms.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants