Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use :first-child #10

Closed
LukyVj opened this issue May 23, 2016 · 6 comments
Closed

Use :first-child #10

LukyVj opened this issue May 23, 2016 · 6 comments
Labels
enhancement

Comments

@LukyVj
Copy link
Owner

LukyVj commented May 23, 2016 •
edited
Loading

Use :first-child instead of :nth-child(1)
:first-child == IE7/8
:nth-child == IE9

https://developer.mozilla.org/fr/docs/Web/CSS/:nth-child
https://developer.mozilla.org/fr/docs/Web/CSS/:first-child
@LukyVj LukyVj changed the title and :last-child Use :first-child May 23, 2016
@LukyVj
Copy link
Owner Author

LukyVj commented May 23, 2016 •
edited
Loading

This :first-child change will occur on a next release of a better Family.scss.

There is actually no mixins that uses :nth-child(1) directly.
To make it happen, I'll use a Sass if/else statement.

Introducing this change right now may seems weird, since I just released the library.

LukyVj added a commit that referenced this issue May 29, 2016
@LukyVj
Release v1.0.3 (#36)
db21504 
### v1.0.3

- `first()` mixin now uses `:first-child` if the given parameter is `1`, closing [#10](#10)
- `n-between()` mixin added ( [see](#) ), closing [#35](#35)
- `at-least()`, `at-most()` and `in-between()` quantity queries mixins added ( [see](#) ), closing [#24](#24)
- `pair-between()` is now `even
-between()`, closing [#34](#34)
- `impair-between()` is now `odd-between()`, closing [#34](#34)
- Source code for the header pattern generator added in the about modal
- Version number added in the footer
- `backdrop-filter` removed from the about page
@LukyVj
Copy link
Owner Author

LukyVj commented May 29, 2016

fixed in 003472a

@LukyVj LukyVj closed this as completed May 29, 2016
@qikkeronline
Copy link

@LukyVj just a heads-up; I can't seem to find this fix in the latest build (or I am missing it somehow 👍 )

@LukyVj
Copy link
Owner Author

LukyVj commented May 30, 2016

Hey, thanks for the heads up! You're right, I added it in the sass file from the components folder, but I forgot to update the source file.

You can find it here https://github.com/LukyVj/family.scss/blob/master/source/stylesheets/vendors/_family.scss

Updating it now!

LukyVj added a commit that referenced this issue May 30, 2016
@LukyVj
Fix #10; Update source file
27c936d
@LukyVj
Copy link
Owner Author

LukyVj commented May 30, 2016

Here you go https://github.com/LukyVj/family.scss/blob/master/source/src/family.scss#L5-L16

LukyVj added a commit that referenced this issue May 30, 2016
@LukyVj
Fix #10; Update source file
f528c8c
@qikkeronline
Copy link

Awesome, thanks so much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@LukyVj @qikkeronline