Skip to content

Commit

Permalink
.github/data/map.yml: intel_adsp_cavs*: drop --rimage-tool=... param
Browse files Browse the repository at this point in the history
The `--rimage-tool=...` parameter was added in March 2022 by the very
first map.yml commit (rebased f6d6f1e15022)

But `west sign` has been invoked by `west build` (through CMake) since
commit fad2da3, almost one year ago. At the time, the ability to
sign from west flash was preserved for backwards compatibility.

Today, `west flash` does not invoke `west sign` any more which means
this `--rimage-tool=...` parameter is now ignored.  The CI for more
recent, ACE platforms (MTL, LNL, etc.) does not pass any
`--rimage-tool=...` at all, see evidence in CI runs of zephyrproject-rtos#860

Removing `--rimage-tool=...` from `.github/data/map.yml` will allow
blocking that option in `west flash` (zephyrproject-rtos#860)

Now that Zephyr 3.5 has been released, we need to reduce the number of
rimage use cases and the corresponding validation complexity and
maintenance workload to simplify and accelerate new features like
splitting rimage configuration
files (zephyrproject-rtos#65411)

Signed-off-by: Marc Herbert <[email protected]>
  • Loading branch information
marc-hb authored and LukaszMrugala committed Sep 24, 2024
1 parent d36271a commit 15afc1d
Showing 1 changed file with 0 additions and 7 deletions.
7 changes: 0 additions & 7 deletions .github/data/map.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@
serial_pty: "soc/xtensa/intel_adsp/tools/cavstool_client.py,-s,[email protected]:59145,-l"
runner_params:
- --remote-host=admin-fmos.hf.intel.com:50145
- --rimage-tool=/usr/local/bin/rimage
- connected: false
id: whl1
platform: intel_adsp_cavs18
Expand All @@ -15,7 +14,6 @@
serial_pty: "soc/xtensa/intel_adsp/tools/cavstool_client.py,-s,[email protected]:59143,-l"
runner_params:
- --remote-host=admin-fmos.hf.intel.com:50143
- --rimage-tool=/usr/local/bin/rimage
- connected: true
id: whl2
platform: intel_adsp_cavs18
Expand All @@ -24,7 +22,6 @@
serial_pty: "soc/xtensa/intel_adsp/tools/cavstool_client.py,-s,[email protected]:59144,-l"
runner_params:
- --remote-host=admin-fmos.hf.intel.com:50144
- --rimage-tool=/usr/local/bin/rimage
- connected: false
id: tgl1
platform: intel_adsp_cavs25
Expand All @@ -33,7 +30,6 @@
serial_pty: "soc/xtensa/intel_adsp/tools/cavstool_client.py,-s,[email protected]:59141,-l"
runner_params:
- --remote-host=admin-fmos.hf.intel.com:50141
- --rimage-tool=/usr/local/bin/rimage
- connected: false
id: tgl2
platform: intel_adsp_cavs25
Expand All @@ -42,7 +38,6 @@
serial_pty: "soc/xtensa/intel_adsp/tools/cavstool_client.py,-s,[email protected]:59142,-l"
runner_params:
- --remote-host=admin-fmos.hf.intel.com:50142
- --rimage-tool=/usr/local/bin/rimage
- connected: true
id: tgl3
platform: intel_adsp_cavs25
Expand All @@ -51,7 +46,6 @@
serial_pty: "soc/xtensa/intel_adsp/tools/cavstool_client.py,-s,[email protected]:59146,-l"
runner_params:
- --remote-host=admin-fmos.hf.intel.com:50146
- --rimage-tool=/usr/local/bin/rimage
- connected: true
id: tgl4
platform: intel_adsp_cavs25
Expand All @@ -60,7 +54,6 @@
serial_pty: "soc/xtensa/intel_adsp/tools/cavstool_client.py,-s,[email protected]:59147,-l"
runner_params:
- --remote-host=admin-fmos.hf.intel.com:50147
- --rimage-tool=/usr/local/bin/rimage
- connected: true
available: true
id: '0002451700'
Expand Down

0 comments on commit 15afc1d

Please sign in to comment.