Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Laravel 10 support #36

Merged
merged 11 commits into from
Apr 18, 2023
Merged

Laravel 10 support #36

merged 11 commits into from
Apr 18, 2023

Conversation

Lukasss93
Copy link
Owner

No description provided.

@codecov
Copy link

codecov bot commented Apr 18, 2023

Codecov Report

Patch coverage: 87.50% and project coverage change: -0.11 ⚠️

Comparison is base (378d890) 100.00% compared to head (98039fc) 99.89%.

❗ Current head 98039fc differs from pull request most recent head 3b042a4. Consider uploading reports for the commit 3b042a4 to get more accurate results

Additional details and impacted files
@@              Coverage Diff              @@
##              master      #36      +/-   ##
=============================================
- Coverage     100.00%   99.89%   -0.11%     
- Complexity       260      261       +1     
=============================================
  Files             32       32              
  Lines            951      958       +7     
=============================================
+ Hits             951      957       +6     
- Misses             0        1       +1     
Impacted Files Coverage Δ
src/helpers.php 100.00% <ø> (ø)
src/LarexServiceProvider.php 96.77% <85.71%> (-3.23%) ⬇️
src/Console/LarexRemoveCommand.php 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@NoahNxT
Copy link

NoahNxT commented Apr 18, 2023

Any updates on this? Because this also blocks the crowdin plugin to be functional on L10 & PHP8.2

@Lukasss93
Copy link
Owner Author

Lukasss93 commented Apr 18, 2023

Any updates on this? Because this also blocks the crowdin plugin to be functional on L10 & PHP8.2

Sorry about that. I'm planning to release a new update in the next few days.

@NoahNxT
Copy link

NoahNxT commented Apr 18, 2023

Any updates on this? Because this also blocks the crowdin plugin to be functional on L10 & PHP8.2

Sorry about that. I'm planning to release a new update in the next few days.

Super thanks!

@Lukasss93 Lukasss93 self-assigned this Apr 18, 2023
@Lukasss93 Lukasss93 marked this pull request as ready for review April 18, 2023 20:23
@Lukasss93 Lukasss93 merged commit a74f0ae into master Apr 18, 2023
@Lukasss93 Lukasss93 deleted the laravel-10 branch April 18, 2023 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants