Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libs version update to support latest android studio #18

Open
wants to merge 3 commits into
base: coroutines_course_empty
Choose a base branch
from

Conversation

parmeshtoyou
Copy link

Hi Lukas,
After purchasing the course from udemy, i tried building your branch but it was not succeeded due to Android studio version update.
I have updated required libraries, gradle version and able to build the code on latest android version.

Android Studio Ladybug Feature Drop | 2024.2.2 Canary 4
Build #AI-242.23339.11.2422.12417746, built on September 26, 2024

Please review the changes and we can either keep these code in a new branch or update the existing one.

This will save other new devs time.

Thanks for this course.

@cavega
Copy link

cavega commented Oct 5, 2024

@parmeshtoyou I ran into this same issue yesterday and updated the tools in my local branch.

@LukasLechnerDev It would be very helpful for future students to be able to clone the project and be up-and-running building the project. Would you be able to review this PR created by @parmeshtoyou? Thanks.

@LukasLechnerDev
Copy link
Owner

Thank you @parmeshtoyou for your contribution 💪

Could you please:

  • Address the one comment that I wrote
  • merge master into this MR (I fixed the pipeline)

Then I think we can merge it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants