-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simplify kernel functions #17
Conversation
Codecov Report
@@ Coverage Diff @@
## roadmap_to_2_0 #17 +/- ##
==================================================
Coverage ? 100.00%
==================================================
Files ? 7
Lines ? 236
Branches ? 0
==================================================
Hits ? 236
Misses ? 0
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I approve these changes I see that you have implemented it as we have been talking about.
Kernels have no neighbour value any more, and dim is used to control dimensions with 3 being the default. Allows for easy construction of kernels and defining their derivatives when related to h^dim atleast.
You also updated all the tests I see, which looks good.
A minor note is, the way of writing W you have chosen does not show in the default Julia terminal. Perhaps this should be changed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Had a look through the explanation files, looks fine
I can't reproduce the unicode error you see with |
Ah, maybe that's one of the new |
Since we know the reason, totally fine - keep it as is! |
No description provided.