-
Notifications
You must be signed in to change notification settings - Fork 183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add transitive conversion to Open API 3.0 via Swagger 2.0 #139
Conversation
11174a3
to
d65960b
Compare
LGTM! Very neat and it's nice to have an extensible pipeline. I've just released v2.10.0 of swagger2openapi, it'd be great if you could update the dependency and check there's no errors - whether any changes to the test output look ok. |
apib2swagger has also recently released v1.0.0 |
Managed to update apib2swagger, but I'm having trouble with [email protected]. It seems there's some syntax in reftools that's tripping up browserify...I tried webpack as well but hit the same issue. Did you update reftools in the latest release? |
Yes, 2.10.0 is the first to use reftools. Any idea what is upsetting browserify? I think webpack 3 runs OK over it, but will check. Update: have tested the three routines that should be used from reftools in requirebin (which uses browserify) and they work ok. |
Don't let it hold up your PR if you want to pin to 2.9.x for now. |
Will have a look at the diff. |
Ok swagger2openapi |
Unfortunately still hitting the same problem. For some reason babel isn't replacing function shallowClone(obj) {
let result = {};
for (let p in obj) {
if (obj.hasOwnProperty(p)) {
result[p] = obj[p];
}
}
return result;
} It must be something wrong with the babel configuration. I'm going to merge this in with [email protected], but will try and mess with babel once that's done. |
@MikeRalphson FYI - pretty simple change, but lmk if you have concerns/suggestions. Otherwise I'll merge tomorrow.
Once this is in, I'll update the web demo (#138)