Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIX storybook msw service worker load #1906

Merged
merged 5 commits into from
Dec 29, 2022
Merged

FIX storybook msw service worker load #1906

merged 5 commits into from
Dec 29, 2022

Conversation

shajz
Copy link
Contributor

@shajz shajz commented Nov 8, 2022 •
edited
Loading

Description

  • Fix le chargement du worker msw (le path est en static depuis la racine du serveur, ce qui pose des pbs car en local, il est bien sous / mais sur les serveurs de déploiement, c'est /master ou /PR-1234. En regardant le pathname de l'url, on peut feinter et lui donner le bon path \o/
  • Simplification pour compodoc, on peut intégrer sa génération aux scripts de run et de build (pour que plus personne n'ait le pb au lancement sans documentation.json) et on s'économise un script dans le package.json, sans impact.

@shajz shajz added 🔖🐛 FIX Bug / Visual fix (PR should target Master branch) 🔨 Technical Doesn't affect the output (refactor, dependencies update, cleaning, etc.) labels Nov 8, 2022
@LuccaIntegration
Copy link

👩‍🍳 http://lucca-front.lucca.local/PR-1906/storybook

@jeremie-lucca jeremie-lucca added this to the 10.3.1 milestone Nov 8, 2022
@shajz shajz force-pushed the fix.storybook.msw.service-worker branch from cc6695e to f7f8fc9 Compare November 16, 2022 17:38
@LuccaIntegration
Copy link

👩‍🍳 http://lucca-front.lucca.local/PR-1906/storybook

@jeremie-lucca jeremie-lucca removed this from the 10.3.1 milestone Dec 6, 2022
@LuccaIntegration
Copy link

👩‍🍳 http://lucca-front.lucca.local/PR-1906/storybook

@shajz shajz force-pushed the fix.storybook.msw.service-worker branch from e64b314 to 589d306 Compare December 29, 2022 16:08
@c-3po c-3po bot added the 📖 Documentation changes Requires a Prisme update label Dec 29, 2022
@shajz shajz marked this pull request as ready for review December 29, 2022 17:38
@shajz shajz requested review from a team as code owners December 29, 2022 17:38
@LuccaIntegration
Copy link

👩‍🍳 http://lucca-front.lucca.local/PR-1906/storybook

@shajz shajz merged commit eab9f43 into master Dec 29, 2022
@shajz shajz deleted the fix.storybook.msw.service-worker branch December 29, 2022 17:40
@shajz
Copy link
Contributor Author

shajz commented Dec 29, 2022

Force merge pour débloquer la prod

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeremie-lucca jeremie-lucca jeremie-lucca approved these changes

Assignees
No one assigned
Labels
📖 Documentation changes Requires a Prisme update 🔖🐛 FIX Bug / Visual fix (PR should target Master branch) 🔨 Technical Doesn't affect the output (refactor, dependencies update, cleaning, etc.)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shajz @LuccaIntegration @jeremie-lucca