Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX use es5 syntax #7

Merged
merged 1 commit into from
Apr 25, 2023
Merged

FIX use es5 syntax #7

merged 1 commit into from
Apr 25, 2023

Conversation

shajz
Copy link
Collaborator

@shajz shajz commented Apr 25, 2023

es5 compatibilty

  • removed let -> var
  • this.plugins -> unncessary and didn't work
  • no need to override cordova instance
  • replaced cordova require with exec

used https://jstool.gitlab.io/babel-es6-to-es5/ to convert it automatically

@shajz shajz added the bug Something isn't working label Apr 25, 2023
@shajz shajz requested a review from stubbst April 25, 2023 13:07
@shajz shajz marked this pull request as ready for review April 25, 2023 13:34
@shajz shajz merged commit 7cd11bc into master Apr 25, 2023
@shajz shajz deleted the fix.es5.build branch April 25, 2023 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants