[wip] Initial extraction of scalar rt math #88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
darksv
changed the title
darksv
commented
Aug 8, 2020
Comment on lines
+20
to
+21
| in float halfWidth, | ||
| in float halfHeight, |
There was a problem hiding this comment.
nie wiem czy dzielenie przez 2 jest tutaj tak kosztowne, żeby to przesyłać wyliczone... wysyłałbym tylko width i height
LucasHamera
reviewed
Aug 8, 2020
| : new Optional<float>(); | ||
| } | ||
|
|
||
| public static Color TraceRay(in Ray ray, MyScene scene, int depth) |
There was a problem hiding this comment.
To publiczne zostawiłbym + point, reszta private ?
There was a problem hiding this comment.
jak nie będą potrzebne to można
There was a problem hiding this comment.
Ok, to zrobię #87 i zobaczymy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dobrze jakby najpierw skończyć zwektoryzowaną implementację, a później wydzielić powtarzające się elementy. byłoby wiadomo co jest rzeczywiście potrzebne i stworzyć dla tego odpowiednie abstrakcje.
closes #86