Lodash: Remove completely from notices package (WordPress#41834)

Luc45 · Jun 24, 2022 · ce461d8 · ce461d8
1 parent a972672
commit ce461d8
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 17 deletions.
diff --git a/package-lock.json b/package-lock.json
diff --git a/packages/notices/package.json b/packages/notices/package.json
@@ -27,8 +27,7 @@
 	"dependencies": {
 		"@babel/runtime": "^7.16.0",
 		"@wordpress/a11y": "file:../a11y",
-		"@wordpress/data": "file:../data",
-		"lodash": "^4.17.21"
+		"@wordpress/data": "file:../data"
 	},
 	"peerDependencies": {
 		"react": "^17.0.0"

diff --git a/packages/notices/src/store/actions.js b/packages/notices/src/store/actions.js
@@ -1,8 +1,3 @@
-/**
- * External dependencies
- */
-import { uniqueId } from 'lodash';
-
 /**
  * Internal dependencies
  */
@@ -19,6 +14,8 @@ import { DEFAULT_CONTEXT, DEFAULT_STATUS } from './constants';
  *
  */
 
+let uniqueId = 0;
+
 /**
  * Returns an action object used in signalling that a notice is to be created.
  *
@@ -54,7 +51,7 @@ export function createNotice( status = DEFAULT_STATUS, content, options = {} ) {
 		speak = true,
 		isDismissible = true,
 		context = DEFAULT_CONTEXT,
-		id = uniqueId( context ),
+		id = `${ context }${ ++uniqueId }`,
 		actions = [],
 		type = 'default',
 		__unstableHTML,

diff --git a/packages/notices/src/store/reducer.js b/packages/notices/src/store/reducer.js
@@ -1,8 +1,3 @@
-/**
- * External dependencies
- */
-import { reject } from 'lodash';
-
 /**
  * Internal dependencies
  */
@@ -22,12 +17,12 @@ const notices = onSubKey( 'context' )( ( state = [], action ) => {
 		case 'CREATE_NOTICE':
 			// Avoid duplicates on ID.
 			return [
-				...reject( state, { id: action.notice.id } ),
+				...state.filter( ( { id } ) => id !== action.notice.id ),
 				action.notice,
 			];
 
 		case 'REMOVE_NOTICE':
-			return reject( state, { id: action.id } );
+			return state.filter( ( { id } ) => id !== action.id );
 	}
 
 	return state;