Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ytmusic): Multiple authors/artists #82

Merged
merged 1 commit into from
Jun 27, 2022
Merged

fix(ytmusic): Multiple authors/artists #82

merged 1 commit into from
Jun 27, 2022

Conversation

DanielKrasny
Copy link
Contributor

Pull Request Template

Description

When searching on YTMUSIC client, songs and videos are returned, but it's common that they can have more than one artist or author. For that reason, albums (or views) may show the second artist as their value.
I've fixed the code so artists/authors are returned as array of strings and albums/views are returned correctly.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have checked my code and corrected any misspellings

Changed return types of SongResultItem's key artist and VideoResultItem's key author to array of strings instead of string. Improved way for getting album/views and duration.
@LuanRT
Copy link
Owner

LuanRT commented Jun 27, 2022

Merging this — do note though that this has been fixed in the new parser (see #65), which also offers better support for YouTube Music overall.

Thank you!

@LuanRT LuanRT merged commit 8849a01 into LuanRT:main Jun 27, 2022
@LuanRT LuanRT added the enhancement New feature or request label Sep 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants