-
-
Notifications
You must be signed in to change notification settings - Fork 235
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(parser): Add LiveChatSponsorshipsGiftPurchaseAnnouncement
and LiveChatSponsorshipsHeader
nodes
#793
feat(parser): Add LiveChatSponsorshipsGiftPurchaseAnnouncement
and LiveChatSponsorshipsHeader
nodes
#793
Conversation
…`LiveChatSponsorshipsHeader` nodes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your pull request. Most of it is great, I've just noted two small potential improvements.
src/parser/classes/livechat/items/LiveChatSponsorshipsHeader.ts
Outdated
Show resolved
Hide resolved
src/parser/classes/livechat/items/LiveChatSponsorshipsHeader.ts
Outdated
Show resolved
Hide resolved
src/parser/classes/livechat/items/LiveChatSponsorshipsHeader.ts
Outdated
Show resolved
Hide resolved
src/parser/classes/livechat/items/LiveChatSponsorshipsHeader.ts
Outdated
Show resolved
Hide resolved
Co-authored-by: absidue <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! I'll go ahead and merge it once @absidue approves the changes, as they've also reviewed it.
Add a new parser for the live chat node that appears when someone sends gifted memberships.
Example RawNode data: