feat(EmojiRun): Add is_custom to identify custom emojis #283
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
With normal emojis the
emoji_id
is the actual emoji, so when you display the image it works well as the alt text. Theemoji_id
for custom emojis however is the id of it on YouTube's servers, so a bunch of letters with a slash in the middle, which doesn't work well as an alt text, in those cases using the shortcuts and search terms as the alt text would be more user friendly. To make it easier to handle emojis and custom emojis differently (my first thought was to use this regex/(\p{Emoji_Presentation}|\p{Extended_Pictographic})/u
in the FreeTube code, until i had the thought that YouTube might already do it for us), this PR extracts YouTube'sisCustomEmoji
property.Type of change
Please delete options that are not relevant.
Checklist: