Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(EmojiRun): Add is_custom to identify custom emojis #283

Merged
merged 1 commit into from
Jan 10, 2023

Conversation

absidue
Copy link
Collaborator

@absidue absidue commented Jan 9, 2023

Description

With normal emojis the emoji_id is the actual emoji, so when you display the image it works well as the alt text. The emoji_id for custom emojis however is the id of it on YouTube's servers, so a bunch of letters with a slash in the middle, which doesn't work well as an alt text, in those cases using the shortcuts and search terms as the alt text would be more user friendly. To make it easier to handle emojis and custom emojis differently (my first thought was to use this regex /(\p{Emoji_Presentation}|\p{Extended_Pictographic})/u in the FreeTube code, until i had the thought that YouTube might already do it for us), this PR extracts YouTube's isCustomEmoji property.

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have checked my code and corrected any misspellings

@LuanRT LuanRT merged commit 5a362a0 into LuanRT:main Jan 10, 2023
@absidue absidue deleted the custom-emoji branch January 10, 2023 06:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants