Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: finalize comment section nodes #280

Merged
merged 4 commits into from
Jan 9, 2023
Merged

Conversation

LuanRT
Copy link
Owner

@LuanRT LuanRT commented Jan 9, 2023

Description

This improves parsing in all nodes related to the comment section, implements missing properties and adds new functionality such as sorting the comment section using an existing Comments object.

A few examples:

import { Innertube, UniversalCache } from 'youtubei.js';

(async () => {
  const yt = await Innertube.create({ cache: new UniversalCache(), generate_session_locally: true });

  // Sort comment section using an existing 'Comments' object:
  const comment_section = await yt.getComments('somevideoid');
  const sorted_comments = await comment_section.applySort('NEWEST_FIRST');
  console.log(sorted_comments); 

  // This PR also includes a fix for the comment translation method:
  const top_thread = comment_section.contents.first();
  const translated_comment = await top_thread?.comment?.translate('ru'); // translates to Russian
  console.log(translated_comment);
})();

Closes #278

Type of change

  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have checked my code and corrected any misspellings

@LuanRT LuanRT marked this pull request as ready for review January 9, 2023 11:13
@LuanRT LuanRT merged commit dca61c3 into main Jan 9, 2023
@LuanRT LuanRT deleted the refactor/improve-comments-parser branch January 9, 2023 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Finish CommentThread/Comment nodes
1 participant