Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Danger local https fix #26

Merged
merged 5 commits into from
Jul 20, 2024

Conversation

kumulynja
Copy link
Contributor

This PR adds a feature to enable and build the package with the danger-local-https feature, but it is disabled on default now since it is only a dev-dependency.

@kumulynja
Copy link
Contributor Author

This PR depends on LtbLightning/payjoin-ffi#32. First merge that and then change the dependency back to the LtbLightning's repo here:

// Change:
payjoin_ffi = { git = "https://github.com/kumulynja/payjoin-ffi", branch = "danger-local-https" }
// To:
payjoin_ffi = {git = "https://github.com/LtbLightning/payjoin-ffi", branch="v0.18.0"}

rust/Cargo.lock Outdated Show resolved Hide resolved
rust/Cargo.toml Outdated Show resolved Hide resolved
@kumulynja kumulynja requested a review from BitcoinZavior July 20, 2024 22:12
@BitcoinZavior BitcoinZavior merged commit c7c18e7 into LtbLightning:main Jul 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants