Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate receiver and sender logic in steps #13

Merged
merged 8 commits into from
Jun 24, 2024

Conversation

kumulynja
Copy link
Contributor

This PR, except for some other very small improvements, mainly separates the logic that has to be done on the receiver's side from the logic needed to be done on the sender's side. Before, the response of the receiver was done in the same step as processing that response with the sender's wallet, now there is one step where the receiver creates and signs its response psbt and then the last step is the sender processing the response, signing it and broadcasting it. With this separation it is easier to understand for someone looking at the example to implement it correctly in its own app.

@BitcoinZavior
Copy link
Contributor

@kumulynja thanks, update changelog please for version dev.2

@kumulynja
Copy link
Contributor Author

@kumulynja thanks, update changelog please for version dev.2

Ok, [0.13.0-dev.2] updates are added to CHANGELOG.md now 👍

Copy link
Contributor

@BitcoinZavior BitcoinZavior left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙌 👍

@BitcoinZavior BitcoinZavior merged commit ead5878 into LtbLightning:main Jun 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants