Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release payjoin-ffi-0.21.0 #38

Merged
merged 5 commits into from
Dec 4, 2024
Merged

Release payjoin-ffi-0.21.0 #38

merged 5 commits into from
Dec 4, 2024

Conversation

DanGould
Copy link
Contributor

@DanGould DanGould commented Dec 3, 2024 •
edited
Loading

  • Organize Cargo.toml
  • Adjust implementation to accomodate rust-payjoin 0.21.0
  • Address clippy complaints
    • first with clippy --fix
    • Second manually and with a CI job to test
  • Bump version

@DanGould
Organize Cargo.toml
4eafff8 
- alphabetize
- order sections by custom
@DanGould DanGould changed the title Payjoin v2 rc0 Prepare payjoin-v2-rc0 Dec 3, 2024
@BitcoinZavior
Copy link
Contributor

@DanGould would be good to update the changelog as well

@DanGould
Copy link
Contributor Author

DanGould commented Dec 3, 2024

I usually do that in the commit I actually bump the release number on. We're close but not quite there yet

@DanGould
Copy link
Contributor Author

DanGould commented Dec 3, 2024

Bumped to 0.21.0 and updated CHANGELOG

@DanGould DanGould changed the title Prepare payjoin-v2-rc0 Release payjoin-ffi-0.21.0 Dec 3, 2024
spacebear21
spacebear21 approved these changes Dec 4, 2024
View reviewed changes
Copy link

@spacebear21 spacebear21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK e88472f

@DanGould DanGould merged commit 5230f19 into LtbLightning:main Dec 4, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spacebear21 spacebear21 spacebear21 approved these changes

@BitcoinZavior BitcoinZavior BitcoinZavior approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@DanGould @BitcoinZavior @spacebear21