tr1/data: fix mesh positions in Obelisk of Khamoon #2008
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lahm86
added
OG bug
lahm86
requested review from
rr-,
walkawayy and
aredfan
and removed request for
a team
|
Download the built assets for this pull request: |
This fixes the angle of the drawbridge in Obelisk of Khamoon when open so that Lara's shadow isn't occluded and the artefacts aren't embedded. It also lifts the senet table and lowers the toppled chair in room 57. The toppled chair is also fixed in Return to Egypt and Temple of the Cat. Resolves LostArtefacts#2006.
lahm86
force-pushed
the
issue-2006-obelisk-mesh-fixes
branch
from
54b9ddc to
7e7dac5
Compare
|
Updated to fix the chair in Return to Egypt and Temple of the Cat. |
walkawayy
approved these changes
Dec 12, 2024
aredfan
approved these changes
Dec 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #2006.
Checklist
Description
This fixes the angle of the drawbridge when open so that Lara's shadow isn't occluded and the artefacts aren't embedded. The open door will also extend fully to the wall. The artefact holder mesh is also shifted down slightly to avoid its texture clashing with the bridge, and it's also pushed against the wall. The caveat is that pickups are slightly above the holder mesh, but should be exactly on the open bridge. I can't see a workaround for this as with the mesh in its original position, the texture pushes through the open bridge.
In room 57, the senet table is also lifted and the toppled chair is lowered.
The "frame edit" addition to the injector is a temporary measure, once we have a new file structure in place (and the changes to the engine in line with this) this will become neater and more general purpose. Currently you could only edit the first rotation of the first frame of an animation.
Ref: LostArtefacts/TRXInjectionTool#17