inventory: reset selected item on closing inventory #1882
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This resets the selected key item when the inventory is closed to avoid it being pre-selected to a non-existent item when the inventory is re-opened. Resolves LostArtefacts#1586.
This resets the selected key item when the inventory is closed to avoid it being pre-selected to a non-existent item when the inventory is re-opened. Resolves LostArtefacts#1586.
lahm86
requested review from
rr-,
walkawayy and
aredfan
and removed request for
a team
|
Download the built assets for this pull request: |
rr-
approved these changes
Nov 12, 2024
aredfan
approved these changes
Nov 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1586.
Checklist
Description
Most of this is config noise, the fix is simply setting
g_InvKeysCurrent = 0;after closing the inventory, otherwise the game will try to select a non-existent item if you go back in via Esc > Up (or whatever your bindings are).I've left the option defaulting to
false, in line with the other TR1 glitch fixing options, but LMK what you think about this.The issue has the steps for testing TR2. In TR1, you can try this:
/play 9/tp 77/give rusty/give gold