Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix certain audio samples continuing to play after finishing the level #1793

Merged
merged 2 commits into from
Nov 2, 2024

Conversation

rr-
Copy link
Collaborator

@rr- rr- commented Nov 1, 2024

Checklist

  • I have read the coding conventions
  • I have added a changelog entry about what my pull request accomplishes, or it is an internal change

Description

Resolves #1770.

rr- added 2 commits November 2, 2024 00:48
Since it's completely reversed and no OG calls still rely on it, it's
safe to delete.
@rr- rr- added TRX bug A bug with TRX TR2 labels Nov 1, 2024
@rr- rr- self-assigned this Nov 1, 2024
@rr- rr- requested review from a team as code owners November 1, 2024 23:49
@rr- rr- requested review from lahm86, walkawayy and aredfan and removed request for a team November 1, 2024 23:49
@rr- rr- merged commit 7ad3dc5 into develop Nov 2, 2024
7 checks passed
@rr- rr- deleted the issue-1770-sound-not-stopping branch November 2, 2024 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
TR2 TRX bug A bug with TRX
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

TRX bug: M16 gun noise continues in the end of level stats
2 participants