Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

output: improve anisotropic filter rendering #1512

Merged
merged 1 commit into from
Sep 14, 2024

Conversation

rr-
Copy link
Collaborator

@rr- rr- commented Sep 14, 2024

Checklist

  • I have read the coding conventions
  • I have added a changelog entry about what my pull request accomplishes, or it is an internal change

Description

Resolves #1507. Improves #902.

For a definite solution, we'd need to artifically add a border around each texture face inside texture atlases, hence I keep #902 as open for now.

@rr- rr- added the Enhancement Improvement of an existing feature label Sep 14, 2024
@rr- rr- added this to the 4.4 milestone Sep 14, 2024
@rr- rr- self-assigned this Sep 14, 2024
@rr- rr- requested review from a team as code owners September 14, 2024 09:03
@rr- rr- requested review from lahm86, walkawayy and aredfan and removed request for a team September 14, 2024 09:03
@rr-
Copy link
Collaborator Author

rr- commented Sep 14, 2024

Actually, hold on – this makes the issue worse in the Gym near the staircase to the piano room. The problem is that the walls are constructed like this:

##
####
######
###### | ######
###### | ######
###### | ######
###### +-------
###### | ######
###### | ######

Since there's 1 quad for the left side and 2 quads for the right side, this causes the calculations to misalign the faces along the | seam.

@lahm86
Copy link
Collaborator

lahm86 commented Sep 14, 2024

Actually, hold on – this makes the issue worse in the Gym near the staircase to the piano room. The problem is that the walls are constructed like this:

##
####
######
###### | ######
###### | ######
###### | ######
###### +-------
###### | ######
###### | ######

Since there's 1 quad for the left side and 2 quads for the right side, this causes the calculations to misalign the faces along the | seam.

I was just testing a TRLE and it's a similar problem there too, and with a skybox present the gaps are much more obvious. I'd imagine this kind of texturing is quite common.

Resolves #1507. Improves #902.

For a definite solution, we'd need to artificially add a border around
each texture face inside texture atlases, hence I'm keeping #902 open
for time being.
@rr- rr- force-pushed the b1507-improved-pretty-pixels branch from 0aff9fa to 1d260af Compare September 14, 2024 09:18
@rr-
Copy link
Collaborator Author

rr- commented Sep 14, 2024

Restored high precision room vertex computing – I don't think this has downgraded the original fix.

@rr- rr- merged commit 8d9b823 into develop Sep 14, 2024
6 checks passed
@rr- rr- deleted the b1507-improved-pretty-pixels branch September 14, 2024 10:14
@rr- rr- added the TR1 label Oct 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement Improvement of an existing feature TR1
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

The Pretty pixels option adds gaps between textures
2 participants