Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix teleport command #1487

Merged
merged 3 commits into from
Sep 3, 2024
Merged

Fix teleport command #1487

merged 3 commits into from
Sep 3, 2024

Conversation

rr-
Copy link
Collaborator

@rr- rr- commented Sep 3, 2024

Checklist

  • I have read the coding conventions
  • I have added a changelog entry about what my pull request accomplishes, or it is an internal change

Description

Resolves #1484 and #1486.

@rr- rr- added TRX bug A bug with TRX Priority: high labels Sep 3, 2024
@rr- rr- added this to the 4.4 milestone Sep 3, 2024
@rr- rr- self-assigned this Sep 3, 2024
@rr- rr- requested review from a team as code owners September 3, 2024 17:25
@rr- rr- requested review from lahm86, walkawayy and aredfan and removed request for a team September 3, 2024 17:25
Copy link
Collaborator

@lahm86 lahm86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but it seems to return failure if you tp when beside a pushblock e.g. room 42 in Midas. Not a big issue imo. I suppose this means "you're already there".

image

src/game/lara/lara_cheat.c Outdated Show resolved Hide resolved
@rr- rr- force-pushed the b1484-tp-cmd-fix branch from 0c54119 to 058d43d Compare September 3, 2024 19:10
@rr-
Copy link
Collaborator Author

rr- commented Sep 3, 2024

@lahm86 fixed

@rr- rr- merged commit 058d43d into develop Sep 3, 2024
6 checks passed
@rr- rr- deleted the b1484-tp-cmd-fix branch September 3, 2024 19:25
@rr- rr- added the TR1 label Oct 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
TR1 TRX bug A bug with TRX
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

TR1X bug: /tp push block doesn't work
3 participants