inventory: set any weapon to default on pickup if unarmed #1445
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aredfan
approved these changes
Aug 15, 2024
There was a problem hiding this comment.
Very nice @walkawayy👍
I tested every combination of 4 weapons picked up, then again with 3 weapons w/o pistols, Lara will always end up drawing the first weapon. This PR also addresses Lahm's anomaly where Lara has magnums/uzis visually holstered and instead draws pistols when starting Atlantis (with pistols as primary weapon disabled).
LGTM.
rr-
reviewed
Aug 15, 2024
lahm86
approved these changes
Aug 15, 2024
rr-
approved these changes
Aug 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1443.
Checklist
Description
Set Lara's default weapon to any weapon she picks up when unarmed, not just pistols.
If you want to move this to 4.4 that's fine, but it seems like it's easy to implement and related to the other gun fixes. I thought we could maybe squeeze it in if there's no bugs. I attached a build for @aredfan to test.
default_weapon_v1 TR1X-4.2-47-g49b582f-Windows.zip