-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
door: fix checking for Lara position #1422
Conversation
Resolves #1419. Removes the proximity test and instead checks if Lara is on the same tile where the ghost block will spawn.
c448e10
to
07a34f0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This LGTM from what I tested, but I'm certainly no expert tester.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me. There is another issue though (and it's present in the current release too). If you save and load behind a door (in this non-portal scenario), Lara will void. The problem I believe is that Door_Initialise
is called on level load and so Lara's position at that point is at the start of the level. The savegame logic will move her to the door's block, but then there are no further checks for door status. Should we tackle this separately?
I have resolved the savegame issue mentioned above. |
Yes, just tried TombATI and you get the same behaviour in that scenario. |
Checklist
Description
Resolves #1419.
Removes the proximity test and instead checks if Lara is on the same tile where the ghost block will spawn.