output: read vertex buffer size from level #1400
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This replaces the fixed vertex buffer size of 1500 with a maximum value read from the level - so the "biggest" room, object or static mesh determines the array size. Resolves LostArtefacts#1398.
rr-
reviewed
Jul 2, 2024
rr-
reviewed
Jul 2, 2024
walkawayy
approved these changes
Jul 2, 2024
rr-
force-pushed
the
issue-1398-vertex-buffer
branch
from
0433e8d to
2ab2e16
Compare
rr-
approved these changes
Jul 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1398.
Checklist
Description
This replaces the fixed vertex buffer size of
1500with a maximum value read from the level - so the "biggest" room, object or static mesh will determine the array size. In most cases it will be the biggest room, but this covers all bases. An alternative to doing the object/static check would be setting an initial value of1500and just iterating over the room meshes, so let me know if that's preferable.