Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TR2X bug: some music triggers loop and others don't repeat #1899

Closed
lahm86 opened this issue Nov 14, 2024 · 1 comment · Fixed by #1905
Closed

TR2X bug: some music triggers loop and others don't repeat #1899

lahm86 opened this issue Nov 14, 2024 · 1 comment · Fixed by #1905
Assignees
Labels
TR2 TRX bug A bug with TRX

Comments

@lahm86
Copy link
Collaborator

lahm86 commented Nov 14, 2024

An example is the trigger at the zip line in Great Wall. Although the trigger isn't one-shot, in OG it only plays once if you stand on the tile, whereas in TR2X it loops until you move away.
One-shot music triggers behave fine.

Another issue is if you complete the assault course and get a best time, then complete and beat the time again without triggering any other music tracks, Lara does not repeat the "best time yet" line at the end.

Regression from 0.2.

@lahm86 lahm86 added TRX bug A bug with TRX TR2 labels Nov 14, 2024
@lahm86 lahm86 moved this to Ready in TRX Dev tracker Nov 14, 2024
@lahm86 lahm86 changed the title TRX bug: some music triggers loop TR2X bug: some music triggers loop Nov 14, 2024
@rr-
Copy link
Collaborator

rr- commented Nov 15, 2024

I think we just need to eliminate g_CD_TrackID in favor of int32_t Music_GetCurrentTrack(void) { return m_TrackCurrent; } in music_main.c.

@lahm86 lahm86 self-assigned this Nov 15, 2024
@lahm86 lahm86 moved this from Ready to In progress in TRX Dev tracker Nov 15, 2024
@lahm86 lahm86 changed the title TR2X bug: some music triggers loop TR2X bug: some music triggers loop and others don't repeat Nov 15, 2024
lahm86 added a commit to lahm86/TRX that referenced this issue Nov 15, 2024
This refactors the way music is checked when requested to play tracks.
Some tracks require to be enforced such as from flip effects, while
others are tracked, such as from regular triggers. Tracked tracks will
not play in succession, provided the mode is the same when requesting
to play them.

Resolves LostArtefacts#1899.
lahm86 added a commit to lahm86/TRX that referenced this issue Nov 16, 2024
This refactors the way music is checked when requested to play tracks.
Some tracks require to be enforced such as from flip effects, while
others are tracked, such as from regular triggers. Tracked tracks will
not play in succession, provided the mode is the same when requesting
to play them.

Resolves LostArtefacts#1899.
@lahm86 lahm86 closed this as completed in 36eec3d Nov 16, 2024
@github-project-automation github-project-automation bot moved this from In progress to Done in TRX Dev tracker Nov 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
TR2 TRX bug A bug with TRX
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants