Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Holding look fully forward causes an upside down frame on release #1338

Closed
walkawayy opened this issue Apr 22, 2024 · 4 comments · Fixed by #1367
Closed

Holding look fully forward causes an upside down frame on release #1338

walkawayy opened this issue Apr 22, 2024 · 4 comments · Fixed by #1367
Assignees
Labels
OG bug A bug in original game TR1
Milestone

Comments

@walkawayy
Copy link
Collaborator

  1. Look forward to the max range.
  2. Release look
  3. While the camera is resetting to normal, an upside down camera frame appears.

20240422_193755_St_Francis_Folly

20240422_193754_St_Francis_Folly

@lahm86 lahm86 added OG bug A bug in original game and removed TRX bug A bug with TRX labels Apr 23, 2024
@lahm86
Copy link
Collaborator

lahm86 commented Apr 23, 2024

This happens in TombATI as well.

@fawtytoo
Copy link

Also happens with PS1 and DOS.

It's not exactly an upside down frame, but more like the camera went slightly past 90 degrees when resetting? At that point maybe something in the code causes it to switch view?

@walkawayy
Copy link
Collaborator Author

@rr- @lahm86

tr1 values are
#define MAX_HEAD_TILT_LOOK (22 * PHD_DEGREE) // = 4004
#define MIN_HEAD_TILT_LOOK (-42 * PHD_DEGREE) // = -7644

and TR4 values:
MAX_HEAD_TILT_LOOK : 5460
MIN_HEAD_TILT_LOOK : -6370

Making that change fixes the issue. But it slightly changes the look angles. Lmk what you think. This is the full forward tilt with TR4 values:

20240510_202348_St_Francis_Folly

@rr-
Copy link
Collaborator

rr- commented May 11, 2024

I think it's OK to change it but I think only one of these two values needs to be adjusted. Ofc with a changelog etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OG bug A bug in original game TR1
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants