Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OG bug: flames are not always drawn when Lara is on fire #1106

Closed
lahm86 opened this issue Dec 9, 2023 · 1 comment · Fixed by #1107
Closed

OG bug: flames are not always drawn when Lara is on fire #1106

lahm86 opened this issue Dec 9, 2023 · 1 comment · Fixed by #1107
Assignees
@lahm86
Labels
OG bug A bug in original game TR1
Milestone
TR1X-3.1

Comments

@lahm86
Copy link
Collaborator

lahm86 commented Dec 9, 2023

If Lara catches fire and then enters a room other than the one where the flames originated, the flames are no longer drawn. They re-appear if she enters the original room, or when she is simply facing that room. Ultimately, the flame FX remain tied to the original room so are only drawn when that room is drawn.

Flame.mp4
@lahm86 lahm86 added the OG bug A bug in original game label Dec 9, 2023
@lahm86 lahm86 added this to the 3.1 milestone Dec 9, 2023
@lahm86 lahm86 self-assigned this Dec 9, 2023
lahm86 added a commit to lahm86/TRX that referenced this issue Dec 9, 2023
@lahm86
flame: tie FX to Lara's room when on fire
1bb640d 
This ensures that if Lara enters a different room while on fire, that
the flame FX are tied to that room so that they will always be drawn.

Resolves LostArtefacts#1106.
@lahm86 lahm86 mentioned this issue Dec 9, 2023
Merged
2 tasks
@aredfan
Copy link
Collaborator

aredfan commented Dec 9, 2023

Nice find! Interestingly on TombATI, when Lara enters a different room while on fire, the game crashes.

lahm86 added a commit that referenced this issue Dec 9, 2023
@lahm86
flame: tie FX to Lara's room when on fire (#1107)
97992d9 
This ensures that if Lara enters a different room while on fire, that
the flame FX are tied to that room so that they will always be drawn.

Resolves #1106.
rr- pushed a commit that referenced this issue Dec 13, 2023
@lahm86 @rr-
flame: tie FX to Lara's room when on fire (#1107)
6fca6cd 
This ensures that if Lara enters a different room while on fire, that
the flame FX are tied to that room so that they will always be drawn.

Resolves #1106.
@rr- rr- added the TR1 label Oct 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lahm86 lahm86

Labels
OG bug A bug in original game TR1
Projects
None yet
Milestone
TR1X-3.1
Development

Successfully merging a pull request may close this issue.

flame: tie FX to Lara's room when on fire lahm86/TRX
3 participants
@rr- @lahm86 @aredfan