DRAFT: add safety features: maxCarbEntry, maxAutoIOB #1870
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This draft PR addresses
Safety Features added with this draft design:
Rather than focusing on how to add new user adjustable settings to Loop and then implementing the functional code that uses them, I took the short-cut of adding them to a Settings Bundle for this Draft PR.
These two settings can be adjusted under iOS->Settings->Loop:
This code has been tested and does what I expect.
For example:
I wasn't sure how to implement logging in DoseMath, so I added some print statements.
Example debug output when a correction would cause IOB to exceed maxAutoIOB:
Code Modifications